Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel to 6.3.2 #12725

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Update bazel to 6.3.2 #12725

merged 4 commits into from
Aug 11, 2023

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Aug 11, 2023

What type of PR is this?

Other

What does this PR do? Why is it needed?

This PR updates bazelversion to 6.3.2 and disables legacy runfiles generation for CI. This may result in a build time reduction of 15 to 20% in CI.

Local results show a before and after build time of 5m13s -> 4m29s.

Edit: legacy runfiles generation seems to still be required for spectests.

Which issues(s) does this PR fix?

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner August 11, 2023 16:18
@prestonvanloon prestonvanloon added CI Continuous integration related items OK to merge labels Aug 11, 2023
james-prysm
james-prysm previously approved these changes Aug 11, 2023
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestonvanloon
Copy link
Member Author

@james-prysm I reverted the legacy runfiles flag since it's required for some spectests

@prylabs-bulldozer prylabs-bulldozer bot merged commit a85b444 into develop Aug 11, 2023
@prylabs-bulldozer prylabs-bulldozer bot deleted the update-bazel branch August 11, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration related items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants